Conversation
- Solver is used with a lot of other classes. Mostly done for consistency.
- Without using std namespace, not sure if the method was using double precision parameters.
- Sag can be calculated at any point along the curve. - Tests have been added for Sag methods.
- Now accepts native catenary parameters (unit weight, end point spacing, etc) as well as a target value to determine the horizontal tension. - LineCable has a new method to convert its parameters (constraint, ruling span spacing) to catenary parameters. Uses CatenarySolver to get the ruling span catenary. - LineCableReloader updated to reference the new class interface.
- Coordinate bug fixed when both end points were left of origin. - 3D -> 2D distance projection calculations weren't referencing std namespace functions. - Space padding added for operators (divide/multiply,etc). - Tests updated to calculate coordinates for a varying origin position.
- Without using std namespace, not sure if the method was using double precision parameters.
- Alphabetization
- Base class name is LineCableLoaderBase. Main purpose is to set up the LineCable for a sag-tension analysis. - With a base class in place, a LineCableUnloader can be developed. Many of the setup methods are going to be reused.
- ThermalRating library files added to doxygen. - Fixed any mistakes that showed up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked classes and bug fixes.